Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor #175] 크레딧 저장 내역 함수 통합 #176

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

hyun2371
Copy link
Member

관련 이슈

📑 작업 상세 내용

  • creditHistoryService 타입별로 함수 나눠져 있던 거 통합
    • 서비스 단위 테스트에서 단건 저장은 repository만 호출하므로 테스트 불필요하다고 생각해 삭제

@hyun2371 hyun2371 added the ♻️ refactor 코드 기능 유지하되 코드 변경 label Dec 26, 2024
@hyun2371 hyun2371 requested a review from dudxo December 26, 2024 13:22
@hyun2371 hyun2371 self-assigned this Dec 26, 2024
@hyun2371 hyun2371 linked an issue Dec 26, 2024 that may be closed by this pull request
2 tasks
Copy link

Code Coverage

Overall Project 83.58% -0.09% 🍏
Files changed 87.5% 🍏

File Coverage
CreditHistoryService.java 100% 🍏
ChatInquiryService.java 92.88% 🍏
AnswerService.java 88.57% 🍏
QuestionPostService.java 77.16% -2.54%

Copy link

Test Results

 28 files   28 suites   14s ⏱️
136 tests 134 ✅ 2 💤 0 ❌
137 runs  135 ✅ 2 💤 0 ❌

Results for commit ef6b975.

Copy link
Collaborator

@dudxo dudxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 테스트를 지워서 좋아졌네요 👍
고생하셨습니다!

@hyun2371 hyun2371 merged commit bd67d41 into dev Dec 27, 2024
3 checks passed
@hyun2371 hyun2371 deleted the refactor/#175/integrate-credit-history branch December 27, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ refactor 코드 기능 유지하되 코드 변경
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ 크레딧 내역 저장 함수 통합
2 participants